Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3775: [WIP] add tests for CMO collection profiles #28768

Closed
wants to merge 2 commits into from
Closed

MON-3775: [WIP] add tests for CMO collection profiles #28768

wants to merge 2 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 5, 2024 •
edited
Loading

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2024 •
edited by openshift-ci bot
Loading

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if appropriate metrics are
    available (or unavailable).
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2024 •
edited by openshift-ci bot
Loading

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if the expected
    ServiceMonitors are available.
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rexagod rexagod marked this pull request as ready for review May 5, 2024 23:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2024
@openshift-ci openshift-ci bot requested review from sjenning and soltysh May 5, 2024 23:10
@rexagod rexagod marked this pull request as draft May 6, 2024 01:13
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@rexagod rexagod marked this pull request as ready for review May 7, 2024 19:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@openshift-ci openshift-ci bot requested a review from p0lyn0mial May 7, 2024 19:21
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@rexagod rexagod changed the title MON-3775: add tests for CMO collection profiles MON-3775: [WIP] add tests for CMO collection profiles May 7, 2024
@rexagod rexagod marked this pull request as draft May 8, 2024 01:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: e449b02

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High
[sig-network-edge][Feature:Idling] Unidling [apigroup:apps.openshift.io][apigroup:route.openshift.io] should handle many TCP connections by possibly dropping those over a certain bound [Serial] [Suite:openshift/conformance/serial]
This test has passed 98.57% of 70 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-serial' 'periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
@rexagod rexagod marked this pull request as ready for review May 28, 2024 08:10
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 3ae0a7e

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial IncompleteTests
Tests for this run (27) are below the historical average (435): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

1 similar comment
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 3ae0a7e

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial IncompleteTests
Tests for this run (27) are below the historical average (435): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@rexagod
Copy link
Member Author

rexagod commented Jun 16, 2024

/test e2e-gcp-ovn-techpreview

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 17e960b

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.50% of 3213 runs on release 4.17 [Overall] in the last week.
---
[sig-node] static pods should start after being created
This test has passed 98.20% of 3226 runs on release 4.17 [Overall] in the last week.
---
[sig-node] static pods should start after being created
This test has passed 98.20% of 3226 runs on release 4.17 [Overall] in the last week.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 17e960b

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.50% of 3213 runs on release 4.17 [Overall] in the last week.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 320b63d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.50% of 3218 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-openstack-ovn Low
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should create a TCP Amphora LoadBalancer when LoadBalancerService ingressController is created on Openshift
This test has passed 70.00% of 10 runs on release 4.17 [Overall] in the last week.

Open Bugs
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should create a TCP Amphora LoadBalancer when LoadBalancerService ingressController is created on Openshift
Incorrect route shard host after 4.11->4.12->4.13->4.14 upgrade

1 similar comment
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 320b63d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.50% of 3218 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-openstack-ovn Low
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should create a TCP Amphora LoadBalancer when LoadBalancerService ingressController is created on Openshift
This test has passed 70.00% of 10 runs on release 4.17 [Overall] in the last week.

Open Bugs
[sig-installer][Suite:openshift/openstack][lb][Serial] The Openstack platform should create a TCP Amphora LoadBalancer when LoadBalancerService ingressController is created on Openshift
Incorrect route shard host after 4.11->4.12->4.13->4.14 upgrade

@rexagod rexagod force-pushed the 3775 branch 2 times, most recently from bd126ca to 1d1f42d Compare June 17, 2024 01:09
@rexagod
Copy link
Member Author

rexagod commented Jun 17, 2024

/test e2e-gcp-ovn-techpreview

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 1d1f42d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node IncompleteTests
Tests for this run (16) are below the historical average (1872): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial IncompleteTests
Tests for this run (18) are below the historical average (415): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-csi IncompleteTests
Tests for this run (16) are below the historical average (808): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-gcp-ovn Medium
[sig-node] static pods should start after being created
This test has passed 97.78% of 45 runs on release 4.17 [amd64 gcp ha ovn] in the last week.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 1d1f42d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node IncompleteTests
Tests for this run (16) are below the historical average (1872): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial IncompleteTests
Tests for this run (18) are below the historical average (415): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-csi IncompleteTests
Tests for this run (16) are below the historical average (808): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@rexagod
Copy link
Member Author

rexagod commented Jun 17, 2024

/test e2e-gcp-ovn-techpreview

@rexagod
Copy link
Member Author

rexagod commented Jun 17, 2024

/test e2e-gcp-ovn-techpreview

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 8c33801

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Low
[bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available
This test has passed 50.00% of 2 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
[bz-DNS] clusteroperator/dns should not change condition/Available
This test has passed 0.00% of 2 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
[bz-Storage] clusteroperator/csi-snapshot-controller should not change condition/Available
This test has passed 50.00% of 2 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
[bz-apiserver-auth] clusteroperator/authentication should not change condition/Available
This test has passed 0.00% of 2 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
Showing 4 of 7 test results

@rexagod
MON-3775: add tests for CMO collection profiles
77ea289 
Refer: openshift/enhancements#1298
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod
Copy link
Member Author

rexagod commented Jun 18, 2024

/test e2e-gcp-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview-serial ac235e1 link false /test e2e-gcp-ovn-techpreview-serial
ci/prow/e2e-metal-ipi-ovn 4471f96 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-single-node-serial 4471f96 link false /test e2e-aws-ovn-single-node-serial
ci/prow/verify 4471f96 link true /test verify
ci/prow/e2e-aws-ovn-ipsec-serial 4471f96 link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-openstack-ovn 4471f96 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 4471f96 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 4471f96

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-marketplace
This test has passed 99.52% of 3555 runs on release 4.17 [Overall] in the last week.

@rexagod
Copy link
Member Author

rexagod commented Jun 18, 2024

I think I'll close this PR and open a new one in a bit, for the sake of brevity.

@rexagod rexagod closed this Jun 18, 2024
@rexagod rexagod mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@deads2k deads2k deads2k left review comments

@machine424 machine424 machine424 left review comments

@sjenning sjenning Awaiting requested review from sjenning

@soltysh soltysh Awaiting requested review from soltysh

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@simonpasquier simonpasquier

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rexagod @openshift-ci-robot @openshift-trt-bot @simonpasquier @deads2k @machine424 @openshift-merge-robot